Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Partial fills surplus #414

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Partial fills surplus #414

merged 4 commits into from
Mar 31, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Added surplus calculation for partial fills

image

To Test

Unit tests. Also:

  1. Open a partially filled order such as 0x75d2a7eaa63f9fc651269f64083a92c5bd96c769c29ca8e3014ed95d47f4e6159fa3c00a92ec5f96b1ad2527ab41b3932efeda5864259c2f
  • Surplus should be displayed

@vercel
Copy link

vercel bot commented Mar 31, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback

📖 Storybook ↗︎

@alfetopito alfetopito self-assigned this Mar 31, 2023
@alfetopito alfetopito requested review from a team March 31, 2023 14:43
@coveralls
Copy link

coveralls commented Mar 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4576839695

  • 42 of 42 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 60.963%
Totals Coverage Status
Change from base Build 4563117003: 0.7%
Covered Lines: 864
Relevant Lines: 1230
💛 - Coveralls

@alfetopito alfetopito mentioned this pull request Mar 31, 2023
Merged
elena-zh
elena-zh approved these changes Mar 31, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alfetopito
alfetopito commented Mar 31, 2023
View reviewed changes
anxolin
anxolin approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature. Other than the fact the 4 functions are not too DRY, I'm good, everything looks great.

@anxolin anxolin merged commit a42d3f2 into develop Mar 31, 2023
@alfetopito alfetopito deleted the partial-fills-surplus branch April 3, 2023 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfetopito @coveralls @anxolin @elena-zh