This repository was archived by the owner on Feb 2, 2024. It is now read-only.
[order table] Partial Fills table (BASE BRANCH) #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
added
the
DONT_MERGE
Pull Request Test Coverage Report for Build 4690239573
💛 - Coveralls |
Merged
* Fix error displaying 0% and 100% * Add testing for formatting function * Rmove helper function
* Refactoring to make the code unambiguous and reduced lines of code 38->12 * Fixed displaying of order assets info in <FilledProgress/> * Fixed layout for FillsTable component 1. Added <TokenAmount> component for buy/sell/execution amounts. It helps to display them shorter 2. Fixed displaying of "View batch graph" button, it was too big for mobile view 3. Fixed global layout (in MainWrapper) to fix page with in mobile view. Warning! This change might brake smth in other pages * Fixed filled progress width for DetailsTable in mobile view * Execution price calculation for Fills table * Added invert button for mobile layout * isPriceInverted * Execution time for trades table (#425) * Execution time for trades table * TradesTimestamps type * Fix type * Fix type * Cache for fetchTradesTimestamps() * Fixed blinking of fills table isFirstLoading - seems to be excessive, because we should display loader only once at start and areTokensLoaded is enough * Fixed lint errors and remove node version restriction * Rollback node restriction * Changed isLoading flag meaning in useOrderTrades() Now it actually means isFirstLoading * Fix lint errors (#426)
alfetopito
approved these changes
Apr 10, 2023
alfetopito
removed
the
DONT_MERGE
* Removed old placeholder * Fixed txhash for fill or kill orders * Do not mutate original obj
This was referenced Apr 11, 2023
* Do not show fills tab for fill or kill orders * Hide fills button * Do not show fills tab for orders with single fills * Do not show fills tab if there are no trades * Moved fills button display logic to parent component * Show tx hash for partial fills with single fill * Updated label to be explicit about partial fills * Fixed storybook * Consistently using the same rule for displaying the fills tab, button and tx hash row: When there are 2 trades or more, show fills tab and button, and hide tx hash row * Do not show fills tab if there are no trades 🤦
* Added new component SurplusComponent * Added calculation for trade surplus getTradeSurplus * Added surplus to fills table * Refactored OrderSurplusDisplay to use SurplusComponent * Fixed issue with surplus tooltip * Removed buy amount value by mistake 😅
* Inverted sell amount and buy amount positions on fills table * Removed batch viewer link column from fills tab * Moved surplus column to after buy amount on fills tab * Added total surplus to fills table * Removed `of <total amount>` from filled progress * Partial fills table styling (#443) * partial fills table styling * partial fills table styling * conditional lineBreak for filled amount * Table header arrow wrap * fix arrow green * add surplus green icon to fills * remove bottom border * remove bottom border * fix top padding sticky cards * revert button wrapping --------- Co-authored-by: fairlight <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recreates #251 after rebasing it with the latest from develop.
WIP DEMO: https://explorer-dev-git-partial-fills-table-cowswap.vercel.app/goerli/orders/0x76cb4b2ac25690664ccb2967b5322f17e1d966e31b205cf86a2b1956bf2f5e54dbc682d0ec19bd276fd6c2af4e0189b584bb31e164258bb1?tab=overview
Once it's decent, we can merge.