This repository was archived by the owner on Feb 2, 2024. It is now read-only.
SDK dogfooding #391
Merged
SDK dogfooding #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 4363399208
💛 - Coveralls |
elena-zh
suggested changes
Mar 7, 2023
There was a problem hiding this comment.
Hey @shoom3301 , great job!
But I have found 1 issue that blocks my approval: AppData details is not working in your PR
alfetopito
reviewed
Mar 7, 2023
src/apps/explorer/components/SummaryCardsWidget/VolumeChart/useGetVolumeData.ts
Show resolved
Hide resolved
|
@elena-zh thanks! Fixed |
elena-zh
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Hey @shoom3301 , I'm approving the current PR. However, I found a list of new issues I faced for the updated AppData page, and reported them in #392. It would be great to fix them.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK refactoring: cowprotocol/cow-sdk#97
Changes
optimize-bundlescript, we don't need it since we got rid of redundant dependenciesSupportedChainId,OrderKind,OrderClassimportsmetadataApiSDKusageOrderBookApiGas price strategycode0xandMatchaAPIs due to their irrelevancegetNativePriceby import from SDKsendOrderandsendSignedOrderCancellationform SDK@cowprotocol/contracts, because they are pretty heavy and we don't need them most of the timeOther PRs: https://github.com/cowprotocol/cowswap/pulls?q=is%3Apr+is%3Aclosed+label%3ASDK_dogfooding