This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Using a custom node version on vercel build step #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please post merge review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes vercel build https://github.com/cowprotocol/explorer/actions/runs/4293564849/jobs/7481491163
Default node version on
ubuntu-latestrunners have been recently upgraded from 16 to 18. See actions/runner-images@ce2e896The vercel build did not have a custom version pinned.
Thus, the upstream change broke it.
This PR pins the vercel workflow to the same node version as the parent workflow
To Test
Nothing to be tested.
Need to merge this to develop and observe the development build action