Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Layout improvement #233

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Layout improvement #233

merged 1 commit into from
Oct 6, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Oct 3, 2022 •
edited
Loading

Summary

Closes #229
image

@alongoni alongoni self-assigned this Oct 3, 2022
@alongoni alongoni added app:Explorer Explorer App Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system Protofire labels Oct 3, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3177162932

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.711%
Totals Coverage Status
Change from base Build 3174260248: 0.0%
Covered Lines: 2211
Relevant Lines: 4283
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@alongoni alongoni marked this pull request as ready for review October 4, 2022 12:27
@alongoni
Copy link
Contributor Author

alongoni commented Oct 4, 2022 •
edited
Loading

@elena-zh I've added a small CSS fix to the main wrapper component in order to prevent the footer jumping during the charge.
Due to the charge being completed in a few milliseconds, a loader component is not needed. WDYT?
cc @henrypalacios @ramirotw

@elena-zh
Copy link

elena-zh commented Oct 4, 2022

Hey @alongoni , I like the current implementation. It looks much-much better when the footer is not jumping.
So if the team decides not to add a loader, I'm OKay with this.

henrypalacios
henrypalacios approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@henrypalacios henrypalacios left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @alongoni , each component in the Home is showing its loading status.

Maybe a global loading while Document Object Model is rendering have more sense (But is out of this PR).

@alongoni alongoni merged commit 5c18d52 into develop Oct 6, 2022
@alongoni alongoni deleted the 229-footer-ui-improvement branch October 6, 2022 18:30
@alfetopito alfetopito mentioned this pull request Oct 19, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramirotw ramirotw ramirotw approved these changes

@henrypalacios henrypalacios henrypalacios approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alongoni alongoni

Labels
app:Explorer Explorer App Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a loader to the Home page
5 participants
@alongoni @coveralls @elena-zh @ramirotw @henrypalacios