Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Update Cargo commands to use --workspace instead of --all #128

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

nlordell
Copy link
Contributor

@nlordell nlordell commented Jan 16, 2020

Just update the cargo commands since --all is deprecated. From the help:

$ cargo build --help
# ...
        --all                        Alias for --workspace (deprecated)
        --workspace                  Build all packages in the workspace
# ...

Note that cargo fmt does not support the --workspace flag and --all actually has different semantics to --workspace for other cargo commands. Currently, cargo fmt already formats all packages in the workspace, the --all flag additionally formats packages that are imported via path and are outside of the workspace (see discussion here). So, for this PR we also remove the --all flag as it superfluous.

Test plan

CI

@nlordell nlordell requested review from fleupold and bh2smith January 16, 2020 12:02
@nlordell nlordell merged commit 87895d9 into master Jan 16, 2020
@nlordell nlordell deleted the travis_updates branch January 24, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants