Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[progress bar] Less scary message #556

Merged
merged 7 commits into from
May 31, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented May 20, 2022

Summary

This PR reiterate slightly on the progress bar for order so:

  • We wait longer before showing the scary message (from 90s to 120s)
  • Makes the scary message, less scary
  • Lets the user know what to do in case this is the case
  • Updates 5 times per second the progress bar to avoid some weird effect that was doing (specially visible in Rinkeby)

Before
Screenshot at May 20 15-09-46

After:
May-20-2022 16-23-44

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@anxolin anxolin marked this pull request as ready for review May 20, 2022 15:24
@anxolin anxolin requested review from a team May 20, 2022 15:33
<WarningIcon size={16} />
<StatusMsg> Your order is taking longer than usual.</StatusMsg>
<StatusMsg>
<p>Networks looks slower than usual. Solvers are adjusting gas fees for you!</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>Networks looks slower than usual. Solvers are adjusting gas fees for you!</p>
<p>The network looks slower than usual. Solvers are adjusting gas fees for you!</p>

@@ -5504,6 +5504,27 @@
"@walletconnect/window-metadata" "1.0.0"
detect-browser "5.2.0"

"@walletconnect/browser-utils@^1.7.8":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what caused these updates? No package changes to trigger it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nup, my assumption is that it was not updated.... i didn't do anything else than running yarn

@anxolin anxolin changed the title Small poc progress [progress bar] Less scary message May 20, 2022
@elena-zh
Copy link
Contributor

Hey @anxolin , great changes!

Might be a nitpick, but it seems that I have some performance issues when 2 orders are showing a progress bar. Also, cancel order modal is called with a delay. (not sure, though, as it might be related with internal issues with my PC).

As for the Gnosis safe order, the POC starts showing me the last scary message when the order's status is changed from 'Signing' to 'Open'
image

I have to notice, that most of these cases I mentioned in #454 (comment) , so seems to me that they are not yes addressed.

Anyways, changes LGTM for user session

@anxolin
Copy link
Contributor Author

anxolin commented May 20, 2022

@elena-zh i'll review the performance issue in case is because of the increased update speed, but the other ones should be fixed in the original PR where they were introduced (or in a follow up PR). This one shouldn't introduce anything that affects here.

@anxolin anxolin requested a review from ramirotw May 31, 2022 09:42
@anxolin anxolin merged commit 79bc8fb into ramirotw/issue-392-integrate-progress-bar May 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2022
@alfetopito alfetopito deleted the small-poc-progress branch May 31, 2022 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants