-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[progress bar] Less scary message #556
[progress bar] Less scary message #556
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
|
<WarningIcon size={16} /> | ||
<StatusMsg> Your order is taking longer than usual.</StatusMsg> | ||
<StatusMsg> | ||
<p>Networks looks slower than usual. Solvers are adjusting gas fees for you!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>Networks looks slower than usual. Solvers are adjusting gas fees for you!</p> | |
<p>The network looks slower than usual. Solvers are adjusting gas fees for you!</p> |
@@ -5504,6 +5504,27 @@ | |||
"@walletconnect/window-metadata" "1.0.0" | |||
detect-browser "5.2.0" | |||
|
|||
"@walletconnect/browser-utils@^1.7.8": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what caused these updates? No package changes to trigger it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nup, my assumption is that it was not updated.... i didn't do anything else than running yarn
Hey @anxolin , great changes! Might be a nitpick, but it seems that I have some performance issues when 2 orders are showing a progress bar. Also, cancel order modal is called with a delay. (not sure, though, as it might be related with internal issues with my PC). As for the Gnosis safe order, the POC starts showing me the last scary message when the order's status is changed from 'Signing' to 'Open' I have to notice, that most of these cases I mentioned in #454 (comment) , so seems to me that they are not yes addressed. Anyways, changes LGTM for user session |
@elena-zh i'll review the performance issue in case is because of the increased update speed, but the other ones should be fixed in the original PR where they were introduced (or in a follow up PR). This one shouldn't introduce anything that affects here. |
Summary
This PR reiterate slightly on the progress bar for order so:
90s
to120s
)Before

After:
