fix: reset trade completely if default token is duplicated #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elena-zh
approved these changes
Dec 2, 2024
alfetopito
reviewed
Dec 5, 2024
Comment on lines
62
to
-57
| } | ||
|
|
||
| return () => { | ||
| if (timeoutId) { | ||
| clearTimeout(timeoutId) | ||
| } | ||
| } |
There was a problem hiding this comment.
Don't we need to clear the timeout when the hook umounts?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By default we use token symbols in URL.
But in some cases we can have more than one token with the same symbol.
In this case if we meet a symbol of that token we do:
It works perfectly with everything but WETH :) Because WETH is a default asset and here we go in a trouble.
To avoid that now we check if the token with duplicated symbol is WETH, then we completely clean up the widget assets state.
Fixes #4323
To Test