-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explorer): add search bar in order view #5118
Conversation
@tienshaoku is attempting to deploy a commit to the cow Team on Vercel. A member of the Team first needs to authorize it. |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @tienshaoku , lots of thanks for your valuable contribution! But now I'm thinking that we should have the same field on a user details page: (https://explorer.cow.fi/address/...) |
@elena-zh thank you for the catch! I used only the order view page so was totally unaware of those two views 😆
|
Hey @tienshaoku , awesome! Thank you! I have a tiny nitpick to report: in a mobile view (real device iPhone 13 mini with 17.6.1 OS) the search bar does not have right padding (on every page): Could you please fix this? Thanks! |
@elena-zh not a problem at all! It'll still be cut if the width is < ~280 (px i guess?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienshaoku , great job, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Summary
Adding a search bar in order view s.t. users don't have to go back to homepage to look up other orders!
I used
max-width: 60rem
,padding: 1.6rem
& styled component for consistency with this repo's convention and compatibility.To Test
Search not found
page