refactor: recreate v2 refactor #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
reviewed
Feb 22, 2024
apps/cowswap-frontend/src/modules/limitOrders/hooks/useHandleOrderPlacement.ts
Show resolved
Hide resolved
shoom3301
approved these changes
Feb 22, 2024
shoom3301
approved these changes
Feb 22, 2024
elena-zh
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Hey @alfetopito , works as before with some issues reported in #3899
Base automatically changed from
feat/recreate-v2_fix-price
to
feat/recreate-v2
February 23, 2024 17:26
alfetopito
force-pushed
the
feat/recreate-v2_refactor
branch
from
e49aca1 to
11b4a24
Compare
|
Merging to parent to consolidate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #3845 and #3899.
No functional changes, just refactoring based on the comments #3845 (comment) and #3845 (comment)
To Test