feat(limit): move to open orders after limit placed #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
commented
Feb 20, 2024
| @@ -89,6 +91,8 @@ export function useHandleOrderPlacement( | |||
| setPartiallyFillableOverride(undefined) | |||
| // Reset alternative mode if any | |||
| hideAlternativeOrderModal() | |||
| // Navigate to open orders | |||
| navigateToOpenOrdersTable() | |||
There was a problem hiding this comment.
The main change/feature
shoom3301
reviewed
Feb 20, 2024
apps/cowswap-frontend/src/modules/ordersTable/utils/getOrderParams.test.ts
Outdated
Show resolved
Hide resolved
alfetopito
force-pushed
the
feat/recreate-v2
branch
from
ce1cf00 to
7975583
Compare
alfetopito
force-pushed
the
feat/move-to-open-orders-after-limit-placed
branch
from
8a45af8 to
aec689b
Compare
|
I'll merge to parent PR to consolidate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing comment #3845 (comment)
Move to open orders tab after limit order is placed.
In the process did a big refactor on
ordersTablemoduleTo Test