Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metadata API] Add methods left to complete metadata flow #15

Merged
merged 6 commits into from
Apr 29, 2022
Merged

[Metadata API] Add methods left to complete metadata flow #15

merged 6 commits into from
Apr 29, 2022

Conversation

matextrem
Copy link
Contributor

This PR closes #5

Added the following methods to complete metadata flow:

  • generateAppDataDoc
  • uploadMetadataDocToIpfs

Besides, IPFS logic was moved to the SDK.

Unit tests were added to improve coverage

@matextrem matextrem self-assigned this Apr 21, 2022
@matextrem matextrem added Protofire enhancement New feature or request labels Apr 21, 2022
@coveralls
Copy link
Collaborator

coveralls commented Apr 21, 2022 •
edited
Loading

Coverage Status

Coverage increased (+4.9%) to 60.561% when pulling d81b07f on 5/metadata-methods into d1b9b06 on main.

@github-actions
Copy link

github-actions bot commented Apr 21, 2022 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

alfetopito
alfetopito reviewed Apr 26, 2022
View reviewed changes
ramirotw
ramirotw suggested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@ramirotw ramirotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. The important things to change are the global references to Request, Headers and fetch in the ipfs.ts file.

ramirotw
ramirotw reviewed Apr 27, 2022
View reviewed changes
@matextrem matextrem requested a review from ramirotw April 28, 2022 03:16
alfetopito
alfetopito approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ramirotw ramirotw merged commit dd02548 into main Apr 29, 2022
@ramirotw ramirotw deleted the 5/metadata-methods branch April 29, 2022 10:31
@ramirotw ramirotw mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@ramirotw ramirotw ramirotw approved these changes

Assignees

@matextrem matextrem

Labels
enhancement New feature or request Protofire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metadata] Add methods left to complete metadata flow
4 participants
@matextrem @coveralls @alfetopito @ramirotw