-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attribute exclusion #884
Fix attribute exclusion #884
Conversation
Thanks, can you add a test with attribute doesn't end with |
@MarcoRossignoli I totally forgot about those 😅 Added now. Let me know if you think the test changes are OK. I figured there's no need to create a custom attribute type as the one that originally gave us issues can be referenced directly in the tests. I also didn't add any specific test for this and instead updated the various exclusion tests so they all test this case, too. |
I had to update the |
Thanks I'll take a look asap |
It's ok, it's related to new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thans's!
Closes #883
The following changes have been added additionally: