Write coverage marker to disk immediately. Don't wait for ProcessExit. Fixes #18 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonerdo
requested changes
Apr 4, 2018
There was a problem hiding this comment.
This is a good start but as you can see from the failing test that it takes too long to run. A better approach might be to write to the hits file in batches. E.g write to the file whenever the length of the markers are 100,000 and then re-instantiate the object. Let me know your thoughts.
| @@ -25,13 +24,8 @@ public static void MarkExecuted(string path, string marker) | |||
| { | |||
| _markers.TryAdd(path, new List<string>()); | |||
| _markers[path].Add(marker); | |||
| File.WriteAllLines(path, _markers[path]); | |||
There was a problem hiding this comment.
This won't work on Windows, you'd get a whole lot of File in use by another process errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will slow down tests because of multiple disk writes instead of only writing once at the end of the process. This, in my opinion, is preferable to incorrect results. The reduced speed shouldn't be too noticeable for small tests.