fix(atomic): don't redirect when hovering a instant result & pressing Enter #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
requested review from
olamothe,
fpbrault,
y-lakhdar and
fbeaudoincoveo
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
|
There's a regression here: we still want to navigate/select the product if the product is focused/selected with keyboard |
fbeaudoincoveo
previously approved these changes
Feb 5, 2025
alexprudhomme
force-pushed
the
KIT-3910
branch
from
27308a2 to
7957507
Compare
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
commented
Feb 6, 2025
Comment on lines
-26
to
+28
| const shorterName = name.replace(/^atomic-/, '').toLowerCase(); | ||
| const shorterName = namePascalCase | ||
| .replace(/^Atomic/, '') | ||
| .replace(/^./, (c) => c.toLowerCase()); |
Comment on lines
+124
to
+132
| // Ignore irrelevant files | ||
| if ( | ||
| filename.endsWith('.mdx') || | ||
| filename.endsWith('.new.stories.tsx') || | ||
| filename.endsWith('.spec.ts') || | ||
| filename.includes('e2e') | ||
| ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Was annoying when writing specs
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3910
We now have a new variable in suggestions-manager that tracks they keyboard use. When someone press Enter when having a suggestion/result/recent query selected with the keyboard, it will trigger it's onClick event.
Whenever we stop using the keyboard and using the mouse it resets again which will make the Enter event trigger the query in the search box instead.
I added a lot of tests to write in vitest.