fix(answerConfigurationId): remove internal tag #4922
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmgauthier
requested review from
erocheleau,
SimonMilord,
mmitiche,
olamothe,
fpbrault,
louis-bompart and
alexprudhomme
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
dmgauthier
had a problem deploying
to
PR Artifacts
GitHub Actions
Error
dmgauthier
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
approved these changes
Feb 3, 2025
lbergeron
approved these changes
Feb 3, 2025
dmgauthier
force-pushed
the
fix-SVCC-4631-remove-answer-configuration-id-internal-tags
branch
from
c71a740 to
347b72e
Compare
dmgauthier
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
reviewed
Feb 3, 2025
| @@ -85,7 +85,6 @@ export default class QuanticGeneratedAnswer extends LightningElement { | |||
| */ | |||
| @api withToggle = false; | |||
| /** | |||
| * @internal | |||
There was a problem hiding this comment.
In Quantic we use the tag @api in the JS doc for public properties,
it should be something like this:
/**
* @api
* The unique identifier of the answer configuration to use to generate the answer.
* @type {string}
*/
@api answerConfigurationId;
alexprudhomme
approved these changes
Feb 4, 2025
SimonMilord
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/SVCC-4631
As we are releasing the KnowledgeHub and the Answer manager. It is now legitimate to show this property on the Quantic an Atomic Generate Answer components.