Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(atomic): better dev mode #4920

Merged
merged 13 commits into from
Feb 4, 2025
Merged

chore(atomic): better dev mode #4920

merged 13 commits into from
Feb 4, 2025

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Jan 31, 2025 •
edited
Loading

KIT-3920

Gifcast

npx nx run atomic:dev --stencil for new dev mode with stencil rebuild

npx nx run atomic:dev for new dev mode without

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244 244 0
commerce 355.2 355.2 0
search 415.2 415.2 0
insight 406.4 406.4 0
recommendation 256.2 256.2 0
ssr 409 409 0
ssr-commerce 373 373 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme changed the title chore: better dev mode chore(atomic): better dev mode Feb 3, 2025
@alexprudhomme alexprudhomme marked this pull request as ready for review February 3, 2025 16:25
@alexprudhomme alexprudhomme requested a review from a team as a code owner February 3, 2025 16:25
louis-bompart
louis-bompart approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me 👍 🐩

packages/atomic/scripts/dev.mjs Show resolved Hide resolved
packages/atomic/scripts/dev.mjs Outdated Show resolved Hide resolved
packages/atomic/scripts/path-transform.mjs Show resolved Hide resolved
@alexprudhomme alexprudhomme added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit 3ba383c Feb 4, 2025
124 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3920 branch February 4, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexprudhomme @louis-bompart