Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: keep css imports intact #4901

Merged
merged 6 commits into from
Jan 28, 2025
Merged

chore: keep css imports intact #4901

merged 6 commits into from
Jan 28, 2025

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Jan 27, 2025 •
edited
Loading

This PR ensures that the @import rules are kept as-is to avoid duplication.
It also makes it so all .css files are processed, not just those ending with .tw.css

https://coveord.atlassian.net/browse/KIT-3903

@fpbrault fpbrault requested a review from a team as a code owner January 27, 2025 21:17
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.9 243.9 0
commerce 355.1 355.1 0
search 415 415 0
insight 406.3 406.3 0
recommendation 256.2 256.2 0
ssr 408.9 408.9 0
ssr-commerce 372.9 372.9 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

alexprudhomme
alexprudhomme approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put that file in the /scripts folder during this PR ?

packages/atomic/process-css.mjs Show resolved Hide resolved
alexprudhomme
alexprudhomme reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postcss, postcss-load-config and lightningcss are missing from the pson !

@fpbrault fpbrault added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit fe1f002 Jan 28, 2025
124 checks passed
@fpbrault fpbrault deleted the KIT-3903 branch January 28, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpbrault @alexprudhomme