Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(atomic): test radio-button render function #4896

Merged
merged 8 commits into from
Jan 30, 2025
Merged

test(atomic): test radio-button render function #4896

merged 8 commits into from
Jan 30, 2025

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Jan 24, 2025

  • Add specs for radio-button render function
  • Remove tsconfig dependencies from stencil tsconfig.
  • Add @testing-library/jest-dom to extend Jest’s matchers with additional utilities for testing DOM elements, such as toBeInTheDocument, etc.

https://coveord.atlassian.net/browse/KIT-3898

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.9 243.9 0
commerce 355.1 355.1 0
search 415 415 0
insight 406.3 406.3 0
recommendation 256.2 256.2 0
ssr 408.9 408.9 0
ssr-commerce 372.9 372.9 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@y-lakhdar y-lakhdar marked this pull request as draft January 24, 2025 17:30
@y-lakhdar y-lakhdar marked this pull request as ready for review January 27, 2025 15:59
@y-lakhdar y-lakhdar enabled auto-merge January 27, 2025 16:01
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@y-lakhdar y-lakhdar added this pull request to the merge queue Jan 30, 2025
Merged via the queue into master with commit 7c5ac43 Jan 30, 2025
124 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3898 branch January 30, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants