CBG-4528 remove PushRevWithHistory #7400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4528 remove PushRevWithHistory/PushUnsolicitedRev
This was used to push unsolicited rev and check failure of the message. Instead of wrapping this in blip code, send the message separately and check the actual error.
This is also an intermediate commit for full CBG-4528 but allows removing a large code pathway. The problem with
PushRevWithHistory
was that it calledupsertDoc
so an outgoing pull replication would see the changes. So this had to avoid being called at the same time as a pull replication to avoid a data race.Additionally, the error
TestBlipDeltaSyncPush
was wrapped as followedfmt.Errorf("error %s %s from revResponse: %s", revResponse.Properties["Error-Domain"], revResponse.Properties["Error-Code"], rspBody)
so the assertion was indirect at best since the verfication is ondeltaSrc
.The test doesn't actually set the correct body for the delta but that is OK since the assertion is set on `deltaRev
Pre-review checklist
fmt.Print
,log.Print
, ...)base.UD(docID)
,base.MD(dbName)
)docs/api
Integration Tests
GSI=true,xattrs=true
https://jenkins.sgwdev.com/job/SyncGateway-Integration/2968/