Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-1196 uptake go-blip to make messages.flags atomic #7396

Merged
merged 3 commits into from
Feb 26, 2025
Merged

CBG-1196 uptake go-blip to make messages.flags atomic #7396

merged 3 commits into from
Feb 26, 2025
+35 −60

Conversation

torcolvin
Copy link
Collaborator

CBG-1196 uptake go-blip to make messages.flags atomic

blip.Message is now uncopyable, so I made GetMessages return a copy. This is detected by govet.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin merged commit 4962557 into main Feb 26, 2025
44 checks passed
@torcolvin torcolvin deleted the CBG-1196 branch February 26, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

@adamcfraser adamcfraser Awaiting requested review from adamcfraser

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torcolvin @bbrks @adamcfraser