Feature/issue 2695 rev tree pruning tombstoned branch #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 28, 2017 13:03
…ortestNonTombstonedBranch returned valid generation
|
@tleyden The test failed due to a test framework issue. We added some version compatibility checks a few weeks ago that is causing source provisioning to fail. Are you able to run the test locally to verify until will can fix this? |
|
@sethrosetter yup, already verified locally. |
ajres
approved these changes
Jun 29, 2017
tleyden
added a commit
that referenced
this pull request
Jun 29, 2017
* Add failing test TestPruneRevsSingleTombstonedBranch() * Fix issue by only setting tombstoneGenerationThreshold if tree.FindShortestNonTombstonedBranch returned valid generation * Remove import # Conflicts: # db/revtree.go # db/revtree_test.go
tleyden
added a commit
that referenced
this pull request
Jul 17, 2017
* Add failing test TestPruneRevsSingleTombstonedBranch() * Fix issue by only setting tombstoneGenerationThreshold if tree.FindShortestNonTombstonedBranch returned valid generation * Remove import
tleyden
pushed a commit
that referenced
this pull request
Jul 26, 2017
Cherry pick from master branch commit 933d652 * Add failing test TestPruneRevsSingleTombstonedBranch() * Fix issue by only setting tombstoneGenerationThreshold if tree.FindShortestNonTombstonedBranch returned valid generation * Remove import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2695
#2695 (comment) explains the bug.
Unit tests against couchbase server bucket (in progress)
Functional test re-run (pending)
@sethrosetter can you check the pending functional test cen7-sync-gateway-functional-tests-base-cc/790 and see if that looks correct?