Solve a bug in Disqus #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotes2020
reviewed
Mar 21, 2023
cotes2020
requested changes
Mar 21, 2023
|
Suggestions accepted. |
cotes2020
force-pushed
the
v4vong-patch-2
branch
from
f16dd8e to
d2dfdab
Compare
nabin-nath
added a commit
to nabin-nath/nabin-nath.github.io
that referenced
this pull request
Mar 29, 2023
* chore(deps): upgrade NPM packages * chore: update code style config * refactor(build): modularize JS code - replace gulp with rollup - remove JS output from repo * chore(ci,tools): adapt to changes in JS builds * chore: update configure-pages action (cotes2020#931) * feat: change TOC plugin to `tocbot` (cotes2020#774) * style: improve code style of SCSS & YAML * fix: notch status bar doesn't match theme color (cotes2020#918) Resolves cotes2020#918 * refactor: remove version number from self host config * fix: some console snippets will be incompletely copied Sample: ```console echo $PATH ``` * style: fix scss lint issue type: declaration-block-no-redundant-longhand-properties * feat(ux): turn home page posts into clickable cards (cotes2020#895) Resolves cotes2020#895 * chore: recover accidentally deleted LQIP style * chore(tools): resume git checkout in initialization * chore(tools): add JS dist to gem release * docs: migrate upgrade details to the wiki * chore(release): 5.6.0 * wip * fix: mode-toggle leads to Disqus loading failure (cotes2020#945) * search fix * wip --------- Co-authored-by: Cotes Chung <[email protected]> Co-authored-by: Josh Johanning <[email protected]> Co-authored-by: Song-Zi Vong <[email protected]>
HOKAGO-MEMORIES
added a commit
to HOKAGO-MEMORIES/hokago-memories.github.io
that referenced
this pull request
Jan 18, 2024
…)" This reverts commit 6fec411.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disqus can't be loaded due to an uncaught syntax error: Identifier 'modeToggle' has already been declared at elsewhere. The solution is to use another name.
Type of change
How has this been tested
bash ./tools/test(at the root of the project) locally and passedTest Configuration