Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pages-deploy.yml.hook #1121

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Conversation

Mohamed3nan
Copy link
Contributor

@Mohamed3nan Mohamed3nan commented Jun 30, 2023

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactoring and improving code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Additional context

How has this been tested

  • I have run bash ./tools/test (at the root of the project) locally and passed
  • I have tested this feature in the browser

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mohamed3nan, could you please fill in the description when submitting a PR on github? I almost think it's a PR spam.

@cotes2020 cotes2020 merged commit e4e76f0 into cotes2020:master Jul 2, 2023
@Mohamed3nan
Copy link
Contributor Author

Hi @Mohamed3nan, could you please fill in the description when submitting a PR on github? I almost think it's a PR spam.

Ok, done
sorry, I just upgraded the version because I think it causes some troubles in my case

@Mohamed3nan Mohamed3nan deleted the patch-1 branch July 2, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants