Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AllowUpdate defaults to true #455

Merged
merged 2 commits into from
Mar 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@

### Relayer

* [\#455](https://github.com/cosmos/relayer/pull/455) Set default client parameter to allow governance to update the client if expiry or misbehaviour freezing occurs.

## v0.8.3

**2021/03/12**

### Relayer

* [\#453](https://github.com/cosmos/relayer/pull/453) Fix light block not found error on missing header
* [\#449](https://github.com/cosmos/relayer/pull/449) Close database connection even if error occurs on initialization
* [\#447](https://github.com/cosmos/relayer/pull/447) Add a light client database lock to prevent concurrency panics
Expand Down
4 changes: 2 additions & 2 deletions cmd/raw.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ $ %s tx raw clnt ibc-1 ibc-0 ibconeclient`, appName, appName)),
dstHeader.GetHeight().(clienttypes.Height),
commitmenttypes.GetSDKSpecs(),
relayer.DefaultUpgradePath,
false,
false,
relayer.AllowUpdateAfterExpiry,
relayer.AllowUpdateAfterMisbehaviour,
)

return sendAndPrint([]sdk.Msg{chains[src].CreateClient(
Expand Down
3 changes: 3 additions & 0 deletions relayer/chain.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ var (
rtyAtt = retry.Attempts(rtyAttNum)
rtyDel = retry.Delay(time.Millisecond * 400)
rtyErr = retry.LastErrorOnly(true)

AllowUpdateAfterExpiry = true
AllowUpdateAfterMisbehaviour = true
)

// Chain represents the necessary data for connecting to and indentifying a chain and its counterparites
Expand Down
8 changes: 4 additions & 4 deletions relayer/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ func (c *Chain) CreateClients(dst *Chain) (modified bool, err error) {
dstUpdateHeader.GetHeight().(clienttypes.Height),
commitmenttypes.GetSDKSpecs(),
DefaultUpgradePath,
false,
false,
AllowUpdateAfterExpiry,
AllowUpdateAfterMisbehaviour,
)

// Check if an identical light client already exists
Expand Down Expand Up @@ -113,8 +113,8 @@ func (c *Chain) CreateClients(dst *Chain) (modified bool, err error) {
srcUpdateHeader.GetHeight().(clienttypes.Height),
commitmenttypes.GetSDKSpecs(),
DefaultUpgradePath,
false,
false,
AllowUpdateAfterExpiry,
AllowUpdateAfterMisbehaviour,
)

// Check if an identical light client already exists
Expand Down