Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use resp.Events to parse events instead of logs #1271

Merged
merged 4 commits into from
Sep 5, 2023
Merged

fix: use resp.Events to parse events instead of logs #1271

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03aaa39
fix: use resp.Events to parse events instead of logs
colin-axner Aug 29, 2023
552e893
revert: use legacy behaviour as fallback mechanism
colin-axner Aug 29, 2023
33e466e
refactor: use legacy approach first, fallback onto new parsing approach
colin-axner Aug 29, 2023
2f2c21b
Merge branch 'main' into colin/event-fix
jtieri Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions relayer/chains/cosmos/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,22 @@ func parseEventsFromTxResponse(resp *sdk.TxResponse) []provider.RelayerEvent {
})
}
}

// After SDK v0.50, indexed events are no longer provided in the logs on
// transaction execution, the response events can be directly used
if len(events) == 0 {
for _, event := range resp.Events {
attributes := make(map[string]string)
for _, attribute := range event.Attributes {
attributes[attribute.Key] = attribute.Value
}
events = append(events, provider.RelayerEvent{
EventType: event.Type,
Attributes: attributes,
})
}
}

return events
}

Expand Down