ICS4: Optimize Cancel #1045
Merged
ICS4: Optimize Cancel #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AdityaSripal
commented
Nov 29, 2023
AdityaSripal
commented
- Add explanation of out of sequence logic
- Optimize cancellation
AdityaSripal
requested review from
mpoke,
cwgoes,
colin-axner and
angbrav
as code owners
sangier
reviewed
Dec 1, 2023
| @@ -906,6 +909,10 @@ function cancelChannelUpgrade( | |||
| // If counterparty sequence is less than the current sequence, | |||
| // abort transaction since this error receipt is from a previous upgrade | |||
| abortTransactionUnless(errorReceipt.sequence >= channel.upgradeSequence) | |||
| // fastforward channel sequence to higher sequence so that we can start | |||
| // new handshake on a fresh sequence | |||
| channel.upgradeSequence = errorReceipt.sequence | |||
There was a problem hiding this comment.
That's sweet, indeed without this change we are unable to start a fresh upgrade handshake after a cancelChannelUpgrade datagram is sent.
This PR proposes a different change to achieve the same goal that is in alignment with the implementation. Nonetheless, the solution presented here represents an optimisation, and should be prioritised for the specs.
sangier
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.