MsgTransfer For Eureka #7957

AdityaSripal · 2025-02-11T20:31:07Z

Description

closes: #7958

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

…er-eureka

AdityaSripal · 2025-02-11T20:32:04Z

modules/apps/transfer/types/expected_keepers.go

 // ClientKeeper defines the expected IBC client keeper
-type ClientKeeper interface {
-	GetClientConsensusState(ctx sdk.Context, clientID string) (connection ibcexported.ConsensusState, found bool)


nonsensical method not used

AdityaSripal · 2025-02-11T21:23:20Z

modules/apps/transfer/keeper/msg_server.go

+	_, isIBCV2 = k.clientKeeperV2.GetClientCounterparty(ctx, msg.SourceChannel)
+	if !isIBCV2 {
+		var found bool
+		channel, found = k.channelKeeper.GetChannel(ctx, msg.SourcePort, msg.SourceChannel)
+		if !found {
+			return nil, errorsmod.Wrapf(channeltypes.ErrChannelNotFound, "port ID (%s) channel ID (%s)", msg.SourcePort, msg.SourceChannel)


i could choose to not have clientKeeperV2 in transfer keeper and just send the channelID from the msg directly to chanKeeperV2 and have it error if counterparty doesn't exist. But then we get a counterparty not found error over the channel not found error

AdityaSripal · 2025-02-11T21:23:35Z

modules/apps/transfer/keeper/msg_server.go

+	if isIBCV2 {
+		encoding := msg.Encoding
+		if encoding == "" {
+			encoding = types.EncodingJSON


default to JSON since that is expected ics20-v1 behaviour

AdityaSripal · 2025-02-11T21:24:27Z

modules/apps/transfer/keeper/msg_server.go

+			sender.String(), payload,
+		)
+
+		res, err := k.channelKeeperV2.SendPacket(ctx, msg)


SendPacket will call transfer module's OnSendPacket

AdityaSripal · 2025-02-11T21:27:24Z

modules/apps/transfer/types/msgs.go

@@ -61,6 +61,27 @@ func NewMsgTransfer(
 	}
 }

+// NewMsgTransferWithEncoding creates a new MsgTransfer instance
+// with the provided encoding
+func NewMsgTransferWithEncoding(


Allow users to pass in custom encoding

AdityaSripal · 2025-02-11T21:28:21Z

modules/apps/transfer/v2/ibc_module_test.go

@@ -289,6 +290,15 @@ func (suite *TransferTestSuite) TestOnAckPacket() {
 			suite.Require().True(ok)
 			originalCoin := sdk.NewCoin(tc.sourceDenomToTransfer, amount)

+			msg := types.NewMsgTransferWithEncoding(


Use the transfer endpoint rather than channelKeeper.SendPacket

AdityaSripal · 2025-02-11T21:28:55Z

modules/apps/transfer/keeper/keeper.go

+	ics4Wrapper     porttypes.ICS4Wrapper
+	channelKeeper   types.ChannelKeeper
+	channelKeeperV2 types.ChannelKeeperV2
+	clientKeeperV2  types.ClientKeeperV2


I could remove this if desired

It would be nice to have less stuff to put in here, but what would that mean for the code?

gjermundgaraba · 2025-02-12T14:07:40Z

I reviewed this yesterday, and came to the conclusion that I want to have a more indepth disucssion on how we do this one, because I am not too comfortable with the flag paths needed to make this work.

AdityaSripal · 2025-02-12T23:00:06Z

refactored to have most of the logic pulled out in 2 different fns. If its still not desirable, we can revisit the approach

AdityaSripal · 2025-02-18T22:48:09Z

Not sure why there's so much proto-gen diffs

gjermundgaraba

I think it looks good now, but left a few comments and questions we should resolve before merging

modules/apps/transfer/keeper/msg_server.go

modules/apps/transfer/types/packet.go

gjermundgaraba · 2025-02-21T11:03:36Z

modules/apps/transfer/keeper/keeper.go

+	ics4Wrapper     porttypes.ICS4Wrapper
+	channelKeeper   types.ChannelKeeper
+	channelKeeperV2 types.ChannelKeeperV2
+	clientKeeperV2  types.ClientKeeperV2


It would be nice to have less stuff to put in here, but what would that mean for the code?

simapp/app.go

Co-authored-by: Gjermund Garaba <[email protected]>

sonarqubecloud · 2025-02-21T19:03:44Z

Quality Gate passed for 'ibc-go'

Issues
72 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

* initial progress * progress * initial build and existing tests pass * testing * documentation for tests * refactor * fix regression * Update modules/apps/transfer/types/packet.go Co-authored-by: Gjermund Garaba <[email protected]> * remove clientKeeperv2 necessity in code * remove clientkeeperv2 in transfer keeper --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 9f677ba)

* initial progress * progress * initial build and existing tests pass * testing * documentation for tests * refactor * fix regression * Update modules/apps/transfer/types/packet.go Co-authored-by: Gjermund Garaba <[email protected]> * remove clientKeeperv2 necessity in code * remove clientkeeperv2 in transfer keeper --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 9f677ba) Co-authored-by: Aditya <[email protected]>

* initial progress * progress * initial build and existing tests pass * testing * documentation for tests * refactor * fix regression * Update modules/apps/transfer/types/packet.go Co-authored-by: Gjermund Garaba <[email protected]> * remove clientKeeperv2 necessity in code * remove clientkeeperv2 in transfer keeper --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 9f677ba) # Conflicts: # modules/apps/transfer/types/tx.pb.go

* initial progress * progress * initial build and existing tests pass * testing * documentation for tests * refactor * fix regression * Update modules/apps/transfer/types/packet.go Co-authored-by: Gjermund Garaba <[email protected]> * remove clientKeeperv2 necessity in code * remove clientkeeperv2 in transfer keeper --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 9f677ba)

* MsgTransfer For Eureka (#7957) (#8001) * initial progress * progress * initial build and existing tests pass * testing * documentation for tests * refactor * fix regression * Update modules/apps/transfer/types/packet.go Co-authored-by: Gjermund Garaba <[email protected]> * remove clientKeeperv2 necessity in code * remove clientkeeperv2 in transfer keeper --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 9f677ba) Co-authored-by: Aditya <[email protected]> * Remove 29-fee (#8000) (#8002) * rm 29-fee * rm docs * lint * add back test * doc link fix (cherry picked from commit 972afc2) Co-authored-by: Aditya <[email protected]> * feat: add cli commands for client v2 counterparty (#7997) (#8007) * feat: add client counterparty cli commands * chore: make wasm simapp possible to run more than once * add query to cli * lint (cherry picked from commit eeb8b8a) Co-authored-by: Gjermund Garaba <[email protected]> * chore: add deprecated functions for backwards compat (#8005) (#8009) * chore: add back some deprecated functions * Added DenomPathFromHash as deprecated function * fix docstring (cherry picked from commit 7bd0c6d) Co-authored-by: Gjermund Garaba <[email protected]> * chore: add backport mergify tasks (#7989) (#8015) * chore: add backport mergify tasks * add wasm ibc v10 to mergify backports (cherry picked from commit 11488cf) Co-authored-by: Gjermund Garaba <[email protected]> * chore: use ibc v2 name consistently (#8006) (#8017) (cherry picked from commit a71577c) Co-authored-by: Gjermund Garaba <[email protected]> * callbacks: Error on RecvPacket callback execution (#8014) (#8020) * change behavior of recvPacket * fix tests * error on malformed callback data * CHANGELOG --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit c5a36e4) Co-authored-by: Aditya <[email protected]> * chore(deps): bump google.golang.org/protobuf from 1.36.4 to 1.36.5 (#7920) (#8021) * chore(deps): bump google.golang.org/protobuf from 1.36.4 to 1.36.5 Bumps google.golang.org/protobuf from 1.36.4 to 1.36.5. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * tidy --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit af5b171) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.4.1 (#7969) (#8022) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.2.0 to 6.4.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6.2.0...v6.4.1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: srdtrk <[email protected]> (cherry picked from commit 1f11107) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <[email protected]> * chore: remove remnants of ics20-2 (#8016) (#8045) * chore: remove remnants of ics20-2 * rename FungibleTokenPacketDataV2 to make it clear that its an internal type * fix broken link (cherry picked from commit 40f3240) Co-authored-by: Gjermund Garaba <[email protected]> * chore(deps): bump JamesIves/github-pages-deploy-action (#7991) (#8048) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.7.2 to 4.7.3. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.7.2...v4.7.3) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 205e6af) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golangci/golangci-lint-action from 6.4.1 to 6.5.0 (#7983) (#8049) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.4.1 to 6.5.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6.4.1...v6.5.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 272c09b) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: remove channel upgradability (#8008) (#8053) * feat: remove channel upgradability * lint * basic migration setup * feat: remove channel upgradeability * fix docs * register v10 migration in app module * error on upgrading channels + code review fixes (cherry picked from commit f7b24e1) Co-authored-by: Gjermund Garaba <[email protected]> --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Aditya <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: update sonarqube gh action (#7985) (#7988) (cherry picked from commit fcb6809) Co-authored-by: Gjermund Garaba <[email protected]> * test: fix ica compatibility tests (#7976) (#7994) * test: fix ica compatibility tests * lint * fix event search * lint (cherry picked from commit 22efa6c) Co-authored-by: Gjermund Garaba <[email protected]> * docs: document ICS23 MerklePath (#7993) (#7995) * proto docs * more go docs (cherry picked from commit 0e8a6c9) Co-authored-by: Aditya <[email protected]> * MsgTransfer For Eureka (#7957) (#8001) * initial progress * progress * initial build and existing tests pass * testing * documentation for tests * refactor * fix regression * Update modules/apps/transfer/types/packet.go Co-authored-by: Gjermund Garaba <[email protected]> * remove clientKeeperv2 necessity in code * remove clientkeeperv2 in transfer keeper --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 9f677ba) Co-authored-by: Aditya <[email protected]> * Remove 29-fee (#8000) (#8002) * rm 29-fee * rm docs * lint * add back test * doc link fix (cherry picked from commit 972afc2) Co-authored-by: Aditya <[email protected]> * feat: add cli commands for client v2 counterparty (#7997) (#8007) * feat: add client counterparty cli commands * chore: make wasm simapp possible to run more than once * add query to cli * lint (cherry picked from commit eeb8b8a) Co-authored-by: Gjermund Garaba <[email protected]> * chore: add deprecated functions for backwards compat (#8005) (#8009) * chore: add back some deprecated functions * Added DenomPathFromHash as deprecated function * fix docstring (cherry picked from commit 7bd0c6d) Co-authored-by: Gjermund Garaba <[email protected]> * chore: add backport mergify tasks (#7989) (#8015) * chore: add backport mergify tasks * add wasm ibc v10 to mergify backports (cherry picked from commit 11488cf) Co-authored-by: Gjermund Garaba <[email protected]> * chore: use ibc v2 name consistently (#8006) (#8017) (cherry picked from commit a71577c) Co-authored-by: Gjermund Garaba <[email protected]> * callbacks: Error on RecvPacket callback execution (#8014) (#8020) * change behavior of recvPacket * fix tests * error on malformed callback data * CHANGELOG --------- Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit c5a36e4) Co-authored-by: Aditya <[email protected]> * chore(deps): bump google.golang.org/protobuf from 1.36.4 to 1.36.5 (#7920) (#8021) * chore(deps): bump google.golang.org/protobuf from 1.36.4 to 1.36.5 Bumps google.golang.org/protobuf from 1.36.4 to 1.36.5. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * tidy --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit af5b171) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.4.1 (#7969) (#8022) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.2.0 to 6.4.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6.2.0...v6.4.1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: srdtrk <[email protected]> (cherry picked from commit 1f11107) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <[email protected]> * chore: remove remnants of ics20-2 (#8016) (#8045) * chore: remove remnants of ics20-2 * rename FungibleTokenPacketDataV2 to make it clear that its an internal type * fix broken link (cherry picked from commit 40f3240) Co-authored-by: Gjermund Garaba <[email protected]> * chore(deps): bump JamesIves/github-pages-deploy-action (#7991) (#8048) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.7.2 to 4.7.3. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.7.2...v4.7.3) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 205e6af) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golangci/golangci-lint-action from 6.4.1 to 6.5.0 (#7983) (#8049) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.4.1 to 6.5.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6.4.1...v6.5.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <[email protected]> (cherry picked from commit 272c09b) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: remove channel upgradability (#8008) (#8053) * feat: remove channel upgradability * lint * basic migration setup * feat: remove channel upgradeability * fix docs * register v10 migration in app module * error on upgrading channels + code review fixes (cherry picked from commit f7b24e1) Co-authored-by: Gjermund Garaba <[email protected]> --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Aditya <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

AdityaSripal added 4 commits February 11, 2025 13:47

initial progress

ac136ca

progress

83d35d6

Merge branch 'main' of github.com:cosmos/ibc-go into aditya/msgtransf…

e1f325a

…er-eureka

initial build and existing tests pass

635a2a2

AdityaSripal requested review from gjermundgaraba and srdtrk as code owners February 11, 2025 20:31

AdityaSripal commented Feb 11, 2025

View reviewed changes

testing

556dded

AdityaSripal commented Feb 11, 2025

View reviewed changes

documentation for tests

3e12678

refactor

3e64c07

AdityaSripal added 2 commits February 18, 2025 16:16

merge

6750736

fix regression

b7138c5

Merge branch 'main' into aditya/msgtransfer-eureka

80947c0

gjermundgaraba reviewed Feb 21, 2025

View reviewed changes

AdityaSripal and others added 3 commits February 21, 2025 09:50

Update modules/apps/transfer/types/packet.go

fea0633

Co-authored-by: Gjermund Garaba <[email protected]>

remove clientKeeperv2 necessity in code

80a7547

remove clientkeeperv2 in transfer keeper

2a10a5e

AdityaSripal requested a review from gjermundgaraba February 21, 2025 19:21

gjermundgaraba approved these changes Feb 24, 2025

View reviewed changes

gjermundgaraba added this pull request to the merge queue Feb 24, 2025

Merged via the queue into main with commit 9f677ba Feb 24, 2025
58 of 59 checks passed

gjermundgaraba deleted the aditya/msgtransfer-eureka branch February 24, 2025 08:27

gjermundgaraba added the backport-to-v10.0.x label Feb 24, 2025

mergify bot mentioned this pull request Feb 24, 2025

MsgTransfer For Eureka (backport #7957) #8001

Merged

10 tasks

gjermundgaraba added backport-callbacks-to-v0.3.x+ibc-go-v10.0.x backport-wasm-v0.6.x+ibc-go-v10.0.x-wasmvm-v2.2.x labels Feb 26, 2025

This was referenced Feb 26, 2025

MsgTransfer For Eureka (backport #7957) #8027

Closed

MsgTransfer For Eureka (backport #7957) #8028

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MsgTransfer For Eureka #7957

MsgTransfer For Eureka #7957

AdityaSripal commented Feb 11, 2025 •

edited

Loading

AdityaSripal Feb 11, 2025

AdityaSripal Feb 11, 2025

AdityaSripal Feb 11, 2025

AdityaSripal Feb 11, 2025

AdityaSripal Feb 11, 2025

AdityaSripal Feb 11, 2025

AdityaSripal Feb 11, 2025

gjermundgaraba Feb 21, 2025

gjermundgaraba commented Feb 12, 2025

AdityaSripal commented Feb 12, 2025

AdityaSripal commented Feb 18, 2025

gjermundgaraba left a comment

gjermundgaraba Feb 21, 2025

sonarqubecloud bot commented Feb 21, 2025

MsgTransfer For Eureka #7957

MsgTransfer For Eureka #7957

Conversation

AdityaSripal commented Feb 11, 2025 • edited Loading

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gjermundgaraba commented Feb 12, 2025

AdityaSripal commented Feb 12, 2025

AdityaSripal commented Feb 18, 2025

gjermundgaraba left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 21, 2025

Quality Gate passed for 'ibc-go'

AdityaSripal commented Feb 11, 2025 •

edited

Loading