chore: migrate to core modules #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
aljo242
reviewed
Jan 23, 2025
modules/apps/29-fee/module.go
Outdated
|
|
||
| "cosmossdk.io/client/v2/autocli" | ||
| "cosmossdk.io/core/appmodule" | ||
| appmodulev2 "cosmossdk.io/core/appmodule/v2" |
There was a problem hiding this comment.
nit: let's use the appmodule (not /v2) path because these modules are all using the non-v2 style of module building
There was a problem hiding this comment.
its confusing to have both v2 and non v2 imports here
There was a problem hiding this comment.
10 tasks
|
gjermundgaraba
approved these changes
Jan 25, 2025
|
Great work, looks clean and good to me! 🙌 |
gjermundgaraba
added a commit
that referenced
this pull request
Feb 7, 2025
This reverts commit dcd6a3e.
gjermundgaraba
added a commit
that referenced
this pull request
Feb 7, 2025
* Revert "chore: use context.Context and appmodule.Environment in 08-wasm (#7880)" This reverts commit 98d7e75. * Revert "chore: make all keepers use address codecs (#7896)" This reverts commit 6a1986c. * Revert "chore: migrate to address codec in transfer (#7892)" This reverts commit c0365a3. * Revert "chore: change usage of deprecated module.NewManager in SimApps (#7886)" This reverts commit 3e0a689. * Revert "chore: migrate to core modules (#7866)" This reverts commit dcd6a3e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes deprecated RegisterServices(Configurator) in favor of RegisterServices(grpc) and RegisterMigrations.
ref: #5917
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.