Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chores] Update spell checker #7721

Merged
merged 5 commits into from
Dec 18, 2024
Merged

[chores] Update spell checker #7721

merged 5 commits into from
Dec 18, 2024

Conversation

NisTun
Copy link
Contributor

@NisTun NisTun commented Dec 18, 2024

Description

closes: #7720

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

DimitrisJim
DimitrisJim approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looking forward to trying it!

@NisTun
Copy link
Contributor Author

NisTun commented Dec 18, 2024

hi @damiannolan, could you plz check and merge it too ❤️

damiannolan
damiannolan approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NisTun!

.github/workflows/spell-checker.yml Show resolved Hide resolved
.github/workflows/spell-checker.yml Outdated Show resolved Hide resolved
@damiannolan damiannolan added this pull request to the merge queue Dec 18, 2024
@NisTun
Copy link
Contributor Author

NisTun commented Dec 18, 2024

hi @damiannolan, I dont know why build-test-matrix-wasm error here @@, could you take a look?

@DimitrisJim
Copy link
Contributor

It is unrelated @NisTun, dont worry about it!

Merged via the queue into cosmos:main with commit 24a49b5 Dec 18, 2024
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spellchecker workflow seems ineffective
3 participants
@NisTun @DimitrisJim @damiannolan