Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circuit module #7715

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Remove circuit module #7715

merged 4 commits into from
Dec 18, 2024

Conversation

ikalyak
Copy link
Contributor

@ikalyak ikalyak commented Dec 17, 2024 •
edited by damiannolan
Loading

Description

closes: #7700

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Dec 17, 2024 •
edited
Loading

Hey @ikalyak, thanks for the PR. Not entirely sure the background for this. It would be helpful if you added some context on why you think the circuit module should be removed.

@ikalyak
Copy link
Contributor Author

ikalyak commented Dec 17, 2024

@gjermundgaraba hello, this #7700

damiannolan
damiannolan reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @ikalyak! Could you also remove it from the 08-wasm/testing/simapp?

I think we can keep it in the root ./simapp which we build docker images from in case its even needed for some e2e testing.

@gjermundgaraba the idea was to keep the simapp used for unit testing library as lightweight/trim as possible as circuit isn't a strict requirement for sdk apps.
There may also be other modules that could be removed but I haven't gone through it in depth.

@ikalyak ikalyak requested a review from srdtrk as a code owner December 18, 2024 10:45
damiannolan
damiannolan approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ikalyak!

@damiannolan damiannolan added this pull request to the merge queue Dec 18, 2024
auto-merge was automatically disabled December 18, 2024 11:42

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:42

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:42

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:43

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:44

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:44

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:44

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:44

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:44

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:44

Pull Request is not mergeable

auto-merge was automatically disabled December 18, 2024 11:44

Pull Request is not mergeable

Merged via the queue into cosmos:main with commit 39d8547 Dec 18, 2024
78 of 79 checks passed
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
@gjermundgaraba
Revert "Remove circuit module (#7715)"
d9c43dd 
This reverts commit 39d8547.
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
@gjermundgaraba
Revert "Remove circuit module (#7715)"
5733d0a 
This reverts commit 39d8547.
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
@gjermundgaraba
chore: revert SDK to 0.50 (#7932)
bf71bdd 
* Revert "chore: bump to sdk v0.52-rc.2 (#7882)"

This reverts commit 4e54444.

* Revert "chore: clean up module impls (#7865)"

This reverts commit d91eb00.

* Revert "fix: sanitize gov v1 proposal in e2e tests for compatibility with 0.52 (#7861)"

This reverts commit 39b190a.

* Revert "chore: bump sdk versions (#7843)"

This reverts commit c29c1ab.

* Revert "fix: wasm docker file + wasm simapp gas limit (#7830)"

This reverts commit 7f0cf54.

* Revert "chore: use header service in localhost client (#7757)"

This reverts commit 0bea84d.

* Revert "refactor: ibc core runtime env (#7601)"

This reverts commit f5e1a4c.

* Revert "refactor: use branch service in 29-fee (#7732)"

This reverts commit d50f7ba.

* Revert "chore: address some linter complaints (#7734)"

This reverts commit 83fdb7f.

* Revert "chore: refactor event service to 29-fee (#7728)"

This reverts commit 0b2866d.

* Revert "refactor: update 29-fee to use runtime.Environment (#7617)"

This reverts commit c8dc02c.

* Revert "refactor: use event service in transfer mod (#7725)"

This reverts commit 0e72d08.

* Revert "refactor: update transfer to use runtime.Environment (#7615)"

This reverts commit fd6a78a.

* Revert "Remove circuit module (#7715)"

This reverts commit 39d8547.

* Revert "refactor: use header info for interchain accounts address generation (#7713)"

This reverts commit c15bb5c.

* Revert "refactor: update icahost to use runtime.Environment (#7600)"

This reverts commit 7aae649.

* Revert "chore: update import alias to align (#7710)"

This reverts commit a14feef.

* Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)"

This reverts commit 8575743.

* fix unwanted reverts

* remove invariant

* lint

* last go1.23 change

* remove unecessary testing keeper

* update go version in dockerfile

* fix docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potentially remove circuit module from testing simapp
4 participants
@ikalyak @gjermundgaraba @damiannolan @DimitrisJim