Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for transfer entire balance for vesting accounts #7650

Merged
merged 7 commits into from
Dec 12, 2024
Merged

feat: add support for transfer entire balance for vesting accounts #7650

merged 7 commits into from
Dec 12, 2024

Conversation

gjermundgaraba
Copy link
Contributor

@gjermundgaraba gjermundgaraba commented Dec 9, 2024 •
edited
Loading

Description

This allows for the "transfer entire balance" feature to work for vesting accounts.

closes: #7658

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

DimitrisJim
DimitrisJim approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would be nice to have a corresponding issue for bug, though.

GetBalance shouldn't be used elsewhere atm right? Can be removed from expected keeper interface. (Though it is used in the impl of OnSendPacket for transfer v2 on feat/ibc-eureka where it should also be tweaked)

@gjermundgaraba
Copy link
Contributor Author

Looks good to me. Would be nice to have a corresponding issue for bug, though.

Added!

GetBalance shouldn't be used elsewhere atm right? Can be removed from expected keeper interface. (Though it is used in the impl of OnSendPacket for transfer v2 on feat/ibc-eureka where it should also be tweaked)

Right! Removed it, and will merge this into feat/ibc-eureka and deal with that after this is merged.

@DimitrisJim DimitrisJim disabled auto-merge December 11, 2024 15:22
@DimitrisJim
Copy link
Contributor

I'd slam this in if you feel confidently about it tbh

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
141 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gjermundgaraba
Copy link
Contributor Author

I'd slam this in if you feel confidently about it tbh

I would if I had access to do so :D

@gjermundgaraba gjermundgaraba merged commit b0d5778 into main Dec 12, 2024
70 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/spend-all-vesting-account branch December 12, 2024 12:14
@gjermundgaraba
Copy link
Contributor Author

Oh wait, I did. Nevermind.

mergify bot pushed a commit that referenced this pull request Dec 12, 2024
@gjermundgaraba @mergify
feat: add support for transfer entire balance for vesting accounts (#…
7e7c17b 
…7650)

* fix spendable bug

* remove GetBalance from expected keeper

---------

Co-authored-by: DimitrisJim <[email protected]>
(cherry picked from commit b0d5778)
@mergify mergify bot mentioned this pull request Dec 12, 2024
Merged
10 tasks
gjermundgaraba added a commit that referenced this pull request Dec 12, 2024
@mergify @gjermundgaraba
feat: add support for transfer entire balance for vesting accounts (#…
d42b23b 
…7650) (#7676)

* fix spendable bug

* remove GetBalance from expected keeper

---------

Co-authored-by: DimitrisJim <[email protected]>
(cherry picked from commit b0d5778)

Co-authored-by: Gjermund Garaba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan

Assignees
No one assigned
Labels
backport-to-v9.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for transfer entire balance for vesting accounts
2 participants
@gjermundgaraba @DimitrisJim