Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add runtime Env to icacontroller and fix v0.52 e2e tests #7587

Merged
merged 34 commits into from
Dec 6, 2024
Merged

feat: add runtime Env to icacontroller and fix v0.52 e2e tests #7587

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
346d83d
feat: adding runtime Environment
damiannolan Nov 21, 2024
29ce5f2
chore: run make lint-fix
damiannolan Nov 21, 2024
7e7d17d
chore: remove duplicate import
damiannolan Nov 21, 2024
7e2f699
chore: rm duplicate import
damiannolan Nov 22, 2024
7cb2468
chore: migrate to env KVStoreService in icacontroller
damiannolan Nov 25, 2024
cb93c24
chore: fix duplicate import
damiannolan Nov 25, 2024
f828f09
chore: rm kv store service
damiannolan Nov 25, 2024
d488054
chore: refactor events to use environment
damiannolan Nov 25, 2024
92ecec1
chore: make lint-fix
damiannolan Nov 25, 2024
4660322
chore: make tidy-all
damiannolan Nov 25, 2024
e267e42
chore: rm msg service router from icacontroller
damiannolan Nov 25, 2024
ab1f3f3
fix: remove 32 bit arm arch from callbacks ci builds
damiannolan Nov 25, 2024
8b67d8d
test: try cache false for callbacks linter
damiannolan Nov 25, 2024
e27966b
chore: pin to updated interchaintest fork
chatton Nov 26, 2024
b6fba89
chore: revert relayer count to 10
chatton Nov 26, 2024
c23234d
chore: continued work on upgrading e2e tests to 0.52
chatton Nov 26, 2024
d83116d
chore: transfer e2e passing
chatton Nov 27, 2024
82c5a66
chore: fix upgrade build errors
chatton Nov 27, 2024
06d40e4
chore: bump interchaintest
chatton Nov 27, 2024
a128c03
chore: update sample config
chatton Nov 27, 2024
55b4fbe
chore: reconfigure protoany to use gogoproto any in favour of codec t…
damiannolan Nov 27, 2024
b92bc67
chore: tidy imports in e2e
damiannolan Nov 27, 2024
f9b7314
fix: address failure in module safe query ica e2e test
damiannolan Dec 2, 2024
94a4685
bump golangci version to 1.60
Dec 2, 2024
4f37cf6
lint: remove duplicate import
damiannolan Dec 2, 2024
e24c60f
chore: use gogoprotoany in favour of codec types any. rm ProtoCodecMa…
damiannolan Dec 4, 2024
d70f0c4
chore: bump go version in Dockerfile
damiannolan Dec 4, 2024
5b89030
chore: add todo
damiannolan Dec 4, 2024
5ea5802
lint: fix unnecessary cast
damiannolan Dec 4, 2024
0e64412
deps: upgrade sdk to head of release/v0.52.x, upgrade store to latest…
damiannolan Dec 4, 2024
a0f28fc
deps: bump to head of release/v0.52
damiannolan Dec 4, 2024
785dc47
fix: add unit test to reproduce e2e test failure for ScheduleIBCUpgra…
damiannolan Dec 5, 2024
9057fcb
fix: error in tests
damiannolan Dec 5, 2024
6ad08d9
chore: address comments from pr
damiannolan Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint: fix unnecessary cast
  • Loading branch information
@damiannolan
damiannolan committed Dec 4, 2024
commit 5ea5802abbcb91bbe3ec32ad7fa88e74e9d4284c
7 changes: 2 additions & 5 deletions modules/core/02-client/migrations/v7/genesis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package v7_test
import (
"encoding/json"

"github.com/cosmos/cosmos-sdk/codec"
codectypes "github.com/cosmos/cosmos-sdk/codec/types"
"github.com/cosmos/cosmos-sdk/runtime"

Expand Down Expand Up @@ -69,8 +68,7 @@ func (suite *MigrationsV7TestSuite) TestMigrateGenesisSolomachine() {
// set in store for ease of determining expected genesis
clientStore := suite.chainA.App.GetIBCKeeper().ClientKeeper.ClientStore(suite.chainA.GetContext(), sm.ClientID)

cdc, ok := suite.chainA.App.AppCodec().(*codec.ProtoCodec)
suite.Require().True(ok)
cdc := suite.chainA.App.AppCodec()
v7.RegisterInterfaces(cdc.InterfaceRegistry())

bz, err := cdc.MarshalInterface(legacyClientState)
Expand Down Expand Up @@ -114,8 +112,7 @@ func (suite *MigrationsV7TestSuite) TestMigrateGenesisSolomachine() {
expectedClientGenState, err := ibcclient.ExportGenesis(suite.chainA.GetContext(), suite.chainA.App.GetIBCKeeper().ClientKeeper)
suite.Require().NoError(err)

cdc, ok := suite.chainA.App.AppCodec().(codec.Codec)
suite.Require().True(ok)
cdc := suite.chainA.App.AppCodec()

migrated, err := v7.MigrateGenesis(&clientGenState, cdc)
suite.Require().NoError(err)
Expand Down
Loading