Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regen swagger docs using make proto-swagger-gen #7005

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

DimitrisJim
Copy link
Contributor

Description

as stated in commit message, maybe lets add this to make proto-all?

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@damiannolan
Copy link
Contributor

do we want to backport this?

@DimitrisJim
Copy link
Contributor Author

do we want to backport this?

are swagger docs versioned?

@damiannolan
Copy link
Contributor

do we want to backport this?

are swagger docs versioned?

ah, good question tbh.. I thought you could serve the swagger doc from some http server when running a node so that's why this came to mind. But I'm not 100% sure if it would need to be backported then 🤔

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Aug 7, 2024

let do it if people complain so we don't backport in vain!

@DimitrisJim DimitrisJim added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit f26f709 Aug 7, 2024
24 checks passed
@DimitrisJim DimitrisJim deleted the jim/regen-swagger-docs branch August 7, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants