Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): add forwarded packets to genesis. #6861

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

DimitrisJim
Copy link
Contributor

Description

closes: #6854


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim changed the title fix: add forwarded packets to genesis. fix(transfer): add forwarded packets to genesis. Jul 17, 2024
@DimitrisJim DimitrisJim force-pushed the jim/6854-forward-packets-genesis branch 7 times, most recently from a7ce779 to 87fc0a5 Compare July 23, 2024 09:39
@DimitrisJim DimitrisJim marked this pull request as ready for review July 23, 2024 09:52
@damiannolan damiannolan added the priority PRs that need prompt reviews label Jul 23, 2024
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! The tests are nice 😎 Apologies for the delayed review. Thanks for your patience 🙏

@DimitrisJim DimitrisJim force-pushed the jim/6854-forward-packets-genesis branch from 87fc0a5 to 511847f Compare July 29, 2024 21:21
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for picking this one up 👍

@DimitrisJim DimitrisJim enabled auto-merge August 1, 2024 14:15
@DimitrisJim DimitrisJim added this pull request to the merge queue Aug 1, 2024
Copy link

sonarqubecloud bot commented Aug 1, 2024

Merged via the queue into main with commit b8f944e Aug 1, 2024
68 of 69 checks passed
@DimitrisJim DimitrisJim deleted the jim/6854-forward-packets-genesis branch August 1, 2024 14:37
mergify bot pushed a commit that referenced this pull request Aug 1, 2024
* fix: add forwarded packets to genesis.

* nit: add comment, add if for checking part is as expected.

(cherry picked from commit b8f944e)
colin-axner pushed a commit that referenced this pull request Aug 1, 2024
* fix: add forwarded packets to genesis.

* nit: add comment, add if for checking part is as expected.

(cherry picked from commit b8f944e)

Co-authored-by: DimitrisJim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add forward packets to transfer genesis state
5 participants