Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Denom type in transfer/simulation. #6522

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

DimitrisJim
Copy link
Contributor

Description

still unsure why we need this but updated to use new Denom type.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim force-pushed the jim/use-denom-in-simulation branch from d277b80 to c267e28 Compare June 6, 2024 09:20
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to run the simulation locally?

@colin-axner colin-axner added the priority PRs that need prompt reviews label Jun 11, 2024
@colin-axner
Copy link
Contributor

Have you tried to run the simulation locally?

I would be in favor of adding the sims to our CI just so that we catch any issues before downstream users

Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@colin-axner
Copy link
Contributor

opened #6590

@DimitrisJim DimitrisJim added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit a3ad5b2 Jun 13, 2024
76 of 77 checks passed
@DimitrisJim DimitrisJim deleted the jim/use-denom-in-simulation branch June 13, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants