Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(08-wasm): expose migrate entry point for 08-wasm #6231
feat(08-wasm): expose migrate entry point for 08-wasm #6231
Changes from 7 commits
b29c96a
866d6dd
7e98cb7
9d4a6d2
2d74aaa
204b40e
b6515af
4b7eee7
0e7b454
77b3f6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistency in the use of backticks for command names.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this was wrong, so I took the liberty to fix it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed
new-code-msg
tomigrate-msg
, since this is a JSON-encoded string that is passed to the contract that is being migrated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this cmd also support passing the json msg as a path to a file? We do that on many other cmds that accept some kind of sub msg.
Do you think we should support this? cc. @crodriguezvega @srdtrk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess most contracts for now will not do anything with this message, so most of the times it will be just
{}
? I am fine supporting it already now or adding support for it later.Check warning on line 99 in modules/light-clients/08-wasm/client/cli/tx.go
GitHub Actions / lint