Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use local clock time only for transfer CLI relative timeouts #5908

Merged
merged 11 commits into from
Mar 4, 2024
Merged

refactor: use local clock time only for transfer CLI relative timeouts #5908

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
78e49d6
refactor: use local clock time for relative timeouts in transfer CLI.…
damiannolan Feb 26, 2024
d2f8360
refactor: add absolute timeout timestamps in ica MsgSendTx CLI. Updat…
damiannolan Feb 26, 2024
9f8f941
chore: rm DefaultRelativePacketTimeoutHeight var from transfer pkg types
damiannolan Feb 27, 2024
de2cbf1
imp: update the transfer cli long help to be more informative and con…
damiannolan Feb 27, 2024
6774cb9
refactor: adjust timeout logic from pr suggestions and move default t…
damiannolan Feb 28, 2024
8413176
refactor: ica cli to be consistent with transfer
damiannolan Feb 28, 2024
3f2d0bb
chore: mv ica packet timeout default to cli pkg
damiannolan Feb 28, 2024
bb74388
Merge branch 'main' into damian/3594-use-local-clocktime-for-clis
damiannolan Feb 28, 2024
5627e49
fix: correctly support absolute timeouts in ica sendTx cli
damiannolan Feb 29, 2024
7f673fb
imp: long desc for ica sendTx cli
damiannolan Mar 1, 2024
f59ad22
Merge branch 'main' into damian/3594-use-local-clocktime-for-clis
chatton Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
imp: update the transfer cli long help to be more informative and con… 
…sistent for both height and timestamp timeouts
  • Loading branch information
@damiannolan
damiannolan committed Feb 27, 2024
commit de2cbf19f966c362cbd78330ea633a22ec122f8a
7 changes: 3 additions & 4 deletions modules/apps/transfer/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,9 @@ func NewTransferTxCmd() *cobra.Command {
cmd := &cobra.Command{
Use: "transfer [src-port] [src-channel] [receiver] [amount]",
Short: "Transfer a fungible token through IBC",
Long: strings.TrimSpace(`Transfer a fungible token through IBC. Timeouts can be specified
as absolute using the "absolute-timeouts" flag. Timeout height can be set by passing in the height string
in the form {revision}-{height} using the "packet-timeout-height" flag. Note, relative timeout height is not supported. Relative timeout timestamp
is added to the value of the system user's local clock time. If no timeout value is set then a default relative timeout value of 10 minutes is used.`),
Long: strings.TrimSpace(`Transfer a fungible token through IBC. Timeouts can be specified as absolute using the "absolute-timeouts" flag.
Timeout height can be set by passing in the height string in the form {revision}-{height} using the "packet-timeout-height" flag. Note, relative timeout height is not supported.
Relative timeout timestamp is added to the value of the user's local system clock time using the "packet-timeout-timestamp" flag. If no timeout value is set then a default relative timeout value of 10 minutes is used.`),
Example: fmt.Sprintf("%s tx ibc-transfer transfer [src-port] [src-channel] [receiver] [amount]", version.AppName),
Args: cobra.ExactArgs(4),
RunE: func(cmd *cobra.Command, args []string) error {
Expand Down
Loading