-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make unused block hashes in testing header creation explicit #5857
chore: make unused block hashes in testing header creation explicit #5857
Conversation
48b06fe
to
f1b3d52
Compare
Hi @crodriguezvega @colin-axner, I hope that the IBC team will support some of our engineer contributions to ibc-go by approving workflows running. @tungle-notional is new to Cosmos, and he wants to put his engineering skill to test by learning to contribute to IBC - go. I will ensure that his contributions conform to conventional commits guidelines. If this issue is irrelevent, we will look at other ones. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5857 +/- ##
=========================================
Coverage 81.59% 81.59%
=========================================
Files 199 198 -1
Lines 15167 12103 -3064
=========================================
- Hits 12375 9876 -2499
+ Misses 2326 1765 -561
+ Partials 466 462 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tungle-notional! Welcome to Cosmos and looking forward to more contributions from you!
Thank you @nghuyenthevinh2000 and welcome @tungle-notional! One point of feedback I'd give back is to always make sure you first request to work on a feature by dropping a comment in the issue stating so. This is the easiest way to make sure work is not duplicated and does not go in vain and helps smooth out the contribution process. We have a contributing document https://github.com/cosmos/ibc-go/blob/main/CONTRIBUTING.md to get everyone up to speed. Thanks again for opening the PR and welcome aboard! ❤️ |
|
||
UnusedHash = tmhash.Sum([]byte{0x00}) | ||
// unusedHash is a placeholder hash used for testing. | ||
unusedHash = tmhash.Sum([]byte{0x00}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made this private! its used inside the testing package so we needn't expose it for the time being!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀 thanks again!
Description
closes: #3960
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.