Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add additional test for iterator on fee mw migration #5667

Merged
merged 8 commits into from
Jan 23, 2024
Merged

test: add additional test for iterator on fee mw migration #5667

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cd96536
add migrations test
charleenfei Jan 19, 2024
00d8899
Merge branch 'main' into charly/issue#5637-add-test-case-for-multiple…
charleenfei Jan 22, 2024
210c924
Merge branch 'main' into charly/issue#5637-add-test-case-for-multiple…
charleenfei Jan 22, 2024
fbf93a3
nits: address pr comments
charleenfei Jan 23, 2024
0737d25
Merge branch 'charly/issue#5637-add-test-case-for-multiple-iterations…
charleenfei Jan 23, 2024
f577286
Merge branch 'main' into charly/issue#5637-add-test-case-for-multiple…
charleenfei Jan 23, 2024
e308557
rm dual import
charleenfei Jan 23, 2024
2e76416
Merge branch 'charly/issue#5637-add-test-case-for-multiple-iterations…
charleenfei Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 46 additions & 4 deletions modules/apps/29-fee/keeper/migrations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ func (suite *KeeperTestSuite) TestLegacyTotal() {

func (suite *KeeperTestSuite) TestMigrate1to2() {
var (
fee types.Fee
packetID channeltypes.PacketId
packetID2 channeltypes.PacketId
moduleAcc sdk.AccAddress
refundAcc sdk.AccAddress
initRefundAccBal sdk.Coins
Expand Down Expand Up @@ -52,7 +54,6 @@ func (suite *KeeperTestSuite) TestMigrate1to2() {
{
"success: one fee in escrow",
func() {
fee := types.NewFee(defaultRecvFee, defaultAckFee, defaultTimeoutFee)
packetFee := types.NewPacketFee(fee, refundAcc.String(), []string(nil))
packetFees = []types.PacketFee{packetFee}
},
Expand All @@ -78,8 +79,7 @@ func (suite *KeeperTestSuite) TestMigrate1to2() {
{
"success: many fees with multiple denoms in escrow",
func() {
fee1 := types.NewFee(defaultRecvFee, defaultAckFee, defaultTimeoutFee)
packetFee1 := types.NewPacketFee(fee1, refundAcc.String(), []string(nil))
packetFee1 := types.NewPacketFee(fee, refundAcc.String(), []string(nil))

// mint some tokens to the refund account
denom2 := "denom"
Expand Down Expand Up @@ -118,10 +118,51 @@ func (suite *KeeperTestSuite) TestMigrate1to2() {
suite.Require().Equal(initModuleAccBal.Sub(unusedFee...).Sort(), moduleAccBal)
},
},
{
"success: more than one packet",
func() {
packetFee := types.NewPacketFee(fee, refundAcc.String(), []string(nil))
packetFees = []types.PacketFee{packetFee}

feesToModule := sdk.NewCoins()
charleenfei marked this conversation as resolved.
Show resolved Hide resolved
for _, packetFee := range packetFees {
feesToModule = feesToModule.Add(keeper.LegacyTotal(packetFee.Fee)...)
}

// add second packet to have escrowed fees
packetID2 = channeltypes.NewPacketID(suite.path.EndpointA.ChannelConfig.PortID, suite.path.EndpointA.ChannelID, 2)

if !feesToModule.IsZero() {
// escrow the packet fee for the second packet & store the fee in state
suite.chainA.GetSimApp().IBCFeeKeeper.SetFeesInEscrow(suite.chainA.GetContext(), packetID2, types.NewPacketFees(packetFees))
err := suite.chainA.GetSimApp().BankKeeper.SendCoinsFromAccountToModule(suite.chainA.GetContext(), refundAcc, types.ModuleName, feesToModule)
suite.Require().NoError(err)
}
},
charleenfei marked this conversation as resolved.
Show resolved Hide resolved
func(err error) {
suite.Require().NoError(err)

// ensure that the packet fees are unmodified
expPacketFees := []types.IdentifiedPacketFees{
types.NewIdentifiedPacketFees(packetID, packetFees),
types.NewIdentifiedPacketFees(packetID2, packetFees),
}
suite.Require().Equal(expPacketFees, suite.chainA.GetSimApp().IBCFeeKeeper.GetAllIdentifiedPacketFees(suite.chainA.GetContext()))

// 300 for each packet
unusedFee := sdk.NewCoin(sdk.DefaultBondDenom, sdkmath.NewInt(600))
charleenfei marked this conversation as resolved.
Show resolved Hide resolved
// refund account balance should increase
refundAccBal := suite.chainA.GetSimApp().BankKeeper.GetBalance(suite.chainA.GetContext(), refundAcc, sdk.DefaultBondDenom)
suite.Require().Equal(initRefundAccBal.Add(unusedFee)[0], refundAccBal)

// module account balance should decrease
moduleAccBal := suite.chainA.GetSimApp().BankKeeper.GetBalance(suite.chainA.GetContext(), moduleAcc, sdk.DefaultBondDenom)
suite.Require().Equal(initModuleAccBal.Sub(unusedFee)[0], moduleAccBal)
},
},
{
"failure: invalid refund address",
func() {
fee := types.NewFee(defaultRecvFee, defaultAckFee, defaultTimeoutFee)
packetFee := types.NewPacketFee(fee, "invalid", []string{})
packetFees = []types.PacketFee{packetFee}
},
Expand All @@ -137,6 +178,7 @@ func (suite *KeeperTestSuite) TestMigrate1to2() {
suite.SetupTest()
suite.coordinator.Setup(suite.path)

fee = types.NewFee(defaultRecvFee, defaultAckFee, defaultTimeoutFee)
refundAcc = suite.chainA.SenderAccount.GetAddress()
moduleAcc = suite.chainA.GetSimApp().AccountKeeper.GetModuleAddress(types.ModuleName)
packetID = channeltypes.NewPacketID(suite.path.EndpointA.ChannelConfig.PortID, suite.path.EndpointA.ChannelID, 1)
Expand Down
Loading