feat: 08-wasm light client proxy module for wasm clients (backport #5079) #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Co-authored-by: Steve <[email protected]> Co-authored-by: Jack Zampolin <[email protected]> Co-authored-by: antstalepresh <[email protected]> Co-authored-by: Vladislav Markushin <[email protected]> Co-authored-by: Blas Rodriguez Irizar <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: vuong <[email protected]> Co-authored-by: Vishal Potpelliwar <[email protected]> Co-authored-by: Charly <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Adi <[email protected]> Co-authored-by: chatton <[email protected]> Co-authored-by: colin axnér <[email protected]> Co-authored-by: Charly <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Muku <[email protected]> Co-authored-by: Pham Anh Minh <[email protected]> Co-authored-by: nguyen <[email protected]> (cherry picked from commit 08d36eb) # Conflicts: # .github/dependabot.yml # .github/workflows/e2e-test-workflow-call.yml # .github/workflows/e2e.yaml # .github/workflows/test.yml # .gitignore # Dockerfile # docs/.vuepress/config.js # docs/architecture/adr-027-ibc-wasm.md # docs/client/config.json # docs/client/swagger-ui/swagger.yaml # docs/ibc/proposals.md # e2e/go.mod # e2e/go.sum # e2e/relayer/relayer.go # e2e/sample.config.yaml # e2e/scripts/run-e2e.sh # e2e/tests/core/02-client/client_test.go # e2e/tests/interchain_accounts/base_test.go # e2e/tests/interchain_accounts/gov_test.go # e2e/tests/interchain_accounts/groups_test.go # e2e/tests/interchain_accounts/incentivized_test.go # e2e/tests/interchain_accounts/localhost_test.go # e2e/tests/interchain_accounts/params_test.go # e2e/tests/transfer/base_test.go # e2e/tests/upgrades/genesis_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/codec.go # e2e/testsuite/grpc_query.go # e2e/testsuite/testconfig.go # e2e/testsuite/testsuite.go # e2e/testsuite/tx.go # e2e/testvalues/values.go # go.work.example # modules/core/02-client/types/params.go # scripts/go-lint-all.sh # scripts/go-mod-tidy-all.sh # testing/chain.go
mergify
bot
requested review from
colin-axner,
AdityaSripal,
crodriguezvega and
charleenfei
as code owners
mergify
bot
requested review from
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
DimitrisJim
reviewed
Nov 16, 2023
| @@ -515,11 +516,13 @@ func (chain *TestChain) CreateTMClientHeader(chainID string, blockHeight int64, | |||
| if tmValSet != nil { //nolint:staticcheck | |||
| valSet, err = tmValSet.ToProto() | |||
| require.NoError(chain.T, err) | |||
| valSet.TotalVotingPower = tmValSet.TotalVotingPower() | |||
There was a problem hiding this comment.
see no harm in adding these (and on line 525) but not entirely certain, lmk if I should drop em)
DimitrisJim
force-pushed
the
mergify/bp/08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x/pr-5079
branch
from
cc4f58a to
d98068b
Compare
|
closing in preference to #5153 |
mergify
bot
deleted the
mergify/bp/08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.4.x/pr-5079
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #5079 done by Mergify.
Cherry-pick of 08d36eb has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com