Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed //nolint:staticcheck from deprecated tags #4175

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

lazyfuhrer
Copy link
Contributor

removed //nolint:staticcheck from deprecated tags

Description

closes: #4143

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

removed
//nolint:staticcheck from deprecated tags
@codecov-commenter
Copy link

Codecov Report

Merging #4175 (f4137f9) into main (3bd0044) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4175   +/-   ##
=======================================
  Coverage   78.86%   78.86%           
=======================================
  Files         188      188           
  Lines       12994    12994           
=======================================
  Hits        10248    10248           
  Misses       2317     2317           
  Partials      429      429           
Files Changed Coverage Δ
modules/core/04-channel/keeper/events.go 100.00% <100.00%> (ø)

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙏

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@crodriguezvega crodriguezvega merged commit e827534 into cosmos:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove //notlint:staticcheck for deprecated tags
5 participants