Use enums in channel handshake log

[expertdicer]

Description

closes: #3335

Commit Message / Changelog Entry

nit: Use enums in channel handshake log

see the guidelines for commit messages. (view raw markdown for examples)

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[DimitrisJim]

LGTM, thanks!

[crodriguezvega]

Thanks for all your contributions lately, @expertdicer!

I just realised that we can make the same improvement in the log statements in connection handshake. I opened this issue just now; if you're interested to take it, please comment and I will assign it to you. :)

[expertdicer]

Thanks for all your contributions lately, @expertdicer!

I just realised that we can make the same improvement in the log statements in connection handshake. I opened this issue just now; if you're interested to take it, please comment and I will assign it to you. :)

yes please. Ty

[damiannolan]

Thanks @expertdicer! I think the WriteOpenAckChannel log is incorrect.
If you're picking up #3385 feel free to make a quick change in that :)

Thanks for the PR 🙏

[damiannolan]

In the case of crossing hellos, it may be possible that previous sate could be UNINITIALIZED or INIT.
But I think support for crossing hellos in opening handshakes was removed at some point 🤔