Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: adding channelID to MsgChannelOpenTryResponse #3117

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

damiannolan
Copy link
Contributor

Description

  • Adding channelID to MsgChannelOpenTryResponse

closes: #3116

Commit Message / Changelog Entry

imp: adding channelID to `MsgChannelOpenTryResponse`

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #3117 (09ce277) into main (65f7038) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files         179      179           
  Lines       12436    12437    +1     
=======================================
+ Hits         9767     9768    +1     
  Misses       2243     2243           
  Partials      426      426           
Impacted Files Coverage Δ
modules/core/keeper/msg_server.go 55.17% <100.00%> (+0.09%) ⬆️

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@damiannolan damiannolan merged commit 6ecf7b6 into main Feb 7, 2023
@damiannolan damiannolan deleted the damian/3116-add-channelID-to-try-response branch February 7, 2023 16:41
@damiannolan
Copy link
Contributor Author

Does this release branch exist yet for backport-to-7.1.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add channelID to MsgChannelOpenTryResponse
4 participants