Adding v4 -> v5 upgrade chain test #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
colin-axner
approved these changes
Aug 30, 2022
| func (s *UpgradeTestSuite) TestV4ToV5ChainUpgrade() { | ||
| // TODO: temporarily hard code the version upgrades. | ||
| oldVersion := "v4.0.0" | ||
| targetVersion := "pr-2144" // v5 version with upgrade handler, replace with v5.0.0-rc3 when it is cut. |
There was a problem hiding this comment.
I guess we would need to backport upgrade handlers for each version we want to test?
There was a problem hiding this comment.
yep we won't be able to upgrade anything unless we have them.
| chainA, _ := s.GetChains() | ||
|
|
||
| chainAUser := s.CreateUserOnChainA(ctx, testvalues.StartingTokenAmount) | ||
| s.UpgradeChain(ctx, chainA, chainAUser, "normal upgrade", targetVersion) |
There was a problem hiding this comment.
I guess followup pr's can allow pre/post upgrade checks
There was a problem hiding this comment.
Yes I think we can add before/after transfers in a follow up.
damiannolan
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test which for now uses a hard coded version of v4 and v5 (from this pr)
We can update this to use the next v5 rc tag when the changes are included.
part of: #1908
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes