Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refs to AllowUpdateToExpired/Frozen client booleans #1768

Merged
merged 10 commits into from
Jul 28, 2022
Merged

chore: remove refs to AllowUpdateToExpired/Frozen client booleans #1768

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b5f3fdd
initial removal
charleenfei Jul 21, 2022
fee23d6
start update changelog
charleenfei Jul 22, 2022
e2a4232
Merge branch 'main' into charly/remove_ref_allow_update
charleenfei Jul 22, 2022
c4829cd
rm deprecated tests
charleenfei Jul 22, 2022
2c47b23
Merge branch 'main' into charly/remove_ref_allow_update
charleenfei Jul 26, 2022
595a98d
update CHANGELOG
charleenfei Jul 26, 2022
369d52b
Merge branch 'charly/remove_ref_allow_update' of github.com:cosmos/ib…
charleenfei Jul 26, 2022
f52f450
merge against 02-client-refactor
charleenfei Jul 28, 2022
6065354
update re: comments
charleenfei Jul 28, 2022
370b12b
Merge branch 'main' into charly/remove_ref_allow_update
charleenfei Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update CHANGELOG
  • Loading branch information
@charleenfei
charleenfei committed Jul 26, 2022
commit 595a98d0a39cd9147f03626ffbf81dea1efc5353
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (transfer)[\#1565](https://github.com/cosmos/ibc-go/pull/1565) Removing `NewErrorAcknowledgement` in favour of `channeltypes.NewErrorAcknowledgement`.
* (channel)[\#1565](https://github.com/cosmos/ibc-go/pull/1565) Updating `NewErrorAcknowledgement` to accept an error instead of a string and removing the possibility of non-deterministic writes to application state.
* (core/04-channel)[\#1636](https://github.com/cosmos/ibc-go/pull/1636) Removing `SplitChannelVersion` and `MergeChannelVersions` functions since they are not used.
* (light-clients/tendermint)
* (light-clients/tendermint)[\#1768](https://github.com/cosmos/ibc-go/pull/1768/files) Removed `AllowUpdateAfter...` booleans as they are deprecated (see ADR026)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] maybe we should explicitly list the booleans to make it more clear what exactly was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, i will update!


### State Machine Breaking

Expand Down