Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: routing MsgSubmitMisbehaviour to UpdateClient keeper fn #1188

Merged
merged 5 commits into from
Apr 4, 2022
Merged

refactor: routing MsgSubmitMisbehaviour to UpdateClient keeper fn #1188

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40fbcfd
refactor: routing MsgSubmitMisbehaviour to UpdateClient keeper fn
seantking Mar 29, 2022
30cc078
chore: updating changelog and comment for deprecated notice
seantking Mar 30, 2022
8695295
fix: channel proto file linter issue + adding deprecated flag to MsgS…
seantking Apr 1, 2022
614d818
chore: fix changelog
seantking Apr 1, 2022
e9f2baf
Merge branch '02-client-refactor' into sean/issue#880-route-submit-mi…
seantking Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions modules/core/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ func (k Keeper) UpgradeClient(goCtx context.Context, msg *clienttypes.MsgUpgrade
}

// SubmitMisbehaviour defines a rpc handler method for MsgSubmitMisbehaviour.
// Warning: Legacy code
// This handler is redudant as `MsgUpdateClient` is now capable of handling both a Header and a Misbehaviour
func (k Keeper) SubmitMisbehaviour(goCtx context.Context, msg *clienttypes.MsgSubmitMisbehaviour) (*clienttypes.MsgSubmitMisbehaviourResponse, error) {
ctx := sdk.UnwrapSDKContext(goCtx)

Expand All @@ -87,8 +89,8 @@ func (k Keeper) SubmitMisbehaviour(goCtx context.Context, msg *clienttypes.MsgSu
return nil, err
}

if err := k.ClientKeeper.CheckMisbehaviourAndUpdateState(ctx, msg.ClientId, misbehaviour); err != nil {
return nil, sdkerrors.Wrap(err, "failed to process misbehaviour for IBC client")
if err = k.ClientKeeper.UpdateClient(ctx, msg.ClientId, misbehaviour); err != nil {
return nil, err
damiannolan marked this conversation as resolved.
Show resolved Hide resolved
}

return &clienttypes.MsgSubmitMisbehaviourResponse{}, nil
Expand Down