Skip to content

Commit

Permalink
remaining lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
aljo242 committed Jan 30, 2025
1 parent a808bfe commit 3a17b47
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 5 deletions.
3 changes: 1 addition & 2 deletions e2e/tests/core/03-connection/connection_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
testifysuite "github.com/stretchr/testify/suite"

govtypes "cosmossdk.io/x/gov/types"

"github.com/cosmos/ibc-go/e2e/testsuite"
"github.com/cosmos/ibc-go/e2e/testsuite/query"
"github.com/cosmos/ibc-go/e2e/testvalues"
Expand All @@ -37,7 +38,6 @@ func (s *ConnectionTestSuite) QueryMaxExpectedTimePerBlockParam(ctx context.Cont
s.Require().NoError(err)

return res.Params.MaxExpectedTimePerBlock

}

// TestMaxExpectedTimePerBlockParam tests changing the MaxExpectedTimePerBlock param using a governance proposal
Expand Down Expand Up @@ -73,7 +73,6 @@ func (s *ConnectionTestSuite) TestMaxExpectedTimePerBlockParam() {

msg := connectiontypes.NewMsgUpdateParams(authority.String(), connectiontypes.NewParams(delay))
s.ExecuteAndPassGovV1Proposal(ctx, msg, chainA, chainAWallet)

})

t.Run("validate the param was successfully changed", func(t *testing.T) {
Expand Down
1 change: 1 addition & 0 deletions e2e/tests/transfer/send_enabled_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
testifysuite "github.com/stretchr/testify/suite"

govtypes "cosmossdk.io/x/gov/types"

"github.com/cosmos/ibc-go/e2e/testsuite"
"github.com/cosmos/ibc-go/e2e/testsuite/query"
"github.com/cosmos/ibc-go/e2e/testvalues"
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/27-interchain-accounts/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (AppModule) GetQueryCmd() *cobra.Command {
return cli.GetQueryCmd()
}

func (am AppModule) RegisterMigrations(registrar appmodule.MigrationRegistrar) error {
func (AppModule) RegisterMigrations(_ appmodule.MigrationRegistrar) error {
return nil
}

Expand Down
2 changes: 1 addition & 1 deletion modules/apps/transfer/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (am AppModule) RegisterMigrations(registrar appmodule.MigrationRegistrar) e
if err := registrar.Register(types.ModuleName, 2, m.MigrateTotalEscrowForDenom); err != nil {
return fmt.Errorf("failed to migrate transfer app from version 2 to 3 (total escrow entry migration): %w", err)
}

if err := registrar.Register(types.ModuleName, 4, m.MigrateDenomMetadata); err != nil {
return fmt.Errorf("failed to migrate transfer app from version 4 to 5 (set denom metadata migration): %w", err)
}
Expand Down
1 change: 1 addition & 0 deletions modules/apps/transfer/types/expected_keepers.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"

banktypes "cosmossdk.io/x/bank/types"

sdk "github.com/cosmos/cosmos-sdk/types"

connectiontypes "github.com/cosmos/ibc-go/v9/modules/core/03-connection/types"
Expand Down
2 changes: 1 addition & 1 deletion modules/core/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func (am AppModule) RegisterMigrations(registrar appmodule.MigrationRegistrar) e
if err := registrar.Register(exported.ModuleName, 3, connectionMigrator.Migrate3to4); err != nil {
return err
}

if err := registrar.Register(exported.ModuleName, 6, clientMigrator.MigrateToStatelessLocalhost); err != nil {
return err
}
Expand Down

0 comments on commit 3a17b47

Please sign in to comment.