Skip to content

Commit

Permalink
add migration docs for #2058
Browse files Browse the repository at this point in the history
  • Loading branch information
crodriguezvega committed Sep 7, 2022
1 parent dbb548a commit 179f39e
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions docs/migrations/v4-to-v5.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,12 @@ The `RegisterRESTRoutes` function in `modules/apps/transfer` has been removed.

### ICS27 - Interchain Accounts

The `key` parameter of the `NewKeeper` functions in
The `key` and `msgRouter` parameters of the `NewKeeper` functions in

- `modules/apps/27-interchain-accounts/controller/keeper`
- and `modules/apps/27-interchain-accounts/host/keeper`

is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
have changed type. The `key` parameter is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`), and the `msgRouter` parameter is now of type `*icatypes.MessageRouter` (where `icatypes` is an import alias for `"github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/types"`):

```diff
// NewKeeper creates a new interchain accounts controller Keeper instance
Expand All @@ -146,7 +146,8 @@ func NewKeeper(
channelKeeper icatypes.ChannelKeeper,
portKeeper icatypes.PortKeeper,
scopedKeeper capabilitykeeper.ScopedKeeper,
msgRouter *baseapp.MsgServiceRouter,
- msgRouter *baseapp.MsgServiceRouter,
+ msgRouter *icatypes.MessageRouter,
) Keeper
```

Expand All @@ -161,10 +162,19 @@ func NewKeeper(
portKeeper icatypes.PortKeeper,
accountKeeper icatypes.AccountKeeper,
scopedKeeper capabilitykeeper.ScopedKeeper,
msgRouter *baseapp.MsgServiceRouter,
- msgRouter *baseapp.MsgServiceRouter,
+ msgRouter *icatypes.MessageRouter,
) Keeper
```

The new `MessageRouter` interface is defined as:

```go
type MessageRouter interface {
Handler(msg sdk.Msg) baseapp.MsgServiceHandler
}
```

The `RegisterRESTRoutes` function in `modules/apps/27-interchain-accounts` has been removed.

#### Cosmos SDK message handler responses in packet acknowledgement
Expand Down

0 comments on commit 179f39e

Please sign in to comment.