feat: deferred pruning #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan on testing this either this weekend, or this coming week. Thanks so much for making this! |
czarcas7ic
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Worked with @cool-develope and tested against Osmosis mainnet, no issues thus far!
|
before we tag id like to test on dydx. Ill aim to do it this week, but we can go ahead with the merge with one more approval |
sontrinh16
approved these changes
Apr 9, 2024
|
does this need to be backported? |
cool-develope
added a commit
that referenced
this pull request
Jul 26, 2024
Co-authored-by: Marko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #885
Added the
AsyncPruningoption, it needs to callSetCommittingandUnsetCommittingwhen committing in the store module in the async pruning mode.It doesn't break the original APIs.